Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HoldTillRename: Rename knative-sandbox to knative-extension #1755

Closed

Conversation

davidhadas
Copy link
Contributor

This is an automated PR to replace knative-sandbox strings to knative-extension. Do not merge until productivity renames knative-sandbox org to knative-extension.

@knative-prow knative-prow bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label May 24, 2023
@codecov
Copy link

codecov bot commented May 24, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -1.05% ⚠️

Comparison is base (6eac0d0) 60.68% compared to head (1f4d0fb) 59.63%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1755      +/-   ##
==========================================
- Coverage   60.68%   59.63%   -1.05%     
==========================================
  Files         107      107              
  Lines       13827    13827              
==========================================
- Hits         8391     8246     -145     
- Misses       4606     4745     +139     
- Partials      830      836       +6     
Flag Coverage Δ
e2e-test 35.46% <100.00%> (ø)
e2e-test-oncluster 30.80% <100.00%> (?)
e2e-test-oncluster-runtime 25.63% <100.00%> (?)
e2e-test-runtime-go 25.90% <100.00%> (?)
e2e-test-runtime-node 26.90% <100.00%> (?)
e2e-test-runtime-python 26.90% <100.00%> (?)
e2e-test-runtime-quarkus 27.02% <100.00%> (?)
e2e-test-runtime-springboot 26.01% <100.00%> (?)
e2e-test-runtime-typescript 27.02% <100.00%> (?)
integration-tests ?
unit-tests-macos-latest 48.62% <100.00%> (ø)
unit-tests-ubuntu-latest 49.38% <100.00%> (-0.03%) ⬇️
unit-tests-windows-latest 48.66% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
cmd/repository.go 56.33% <100.00%> (ø)

... and 19 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 14, 2023
@knative-prow-robot knative-prow-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 2, 2023
@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Aug 2, 2023
@knative-prow
Copy link

knative-prow bot commented Aug 2, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: davidhadas, lkingland

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 2, 2023
@davidhadas
Copy link
Contributor Author

changed to extensions

@davidhadas davidhadas closed this Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants